Add support for FNC1 in first position mode - #7
Open
sasosecnjak wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the "FNC1 in first position" mode (
0x5) toQRSegment, in accordance with the QR Code specification. This mode is commonly used for GS1-compliant barcodes.Changes Included:
Mode.fnc1FirstPositionmodeBitsto return0x5for FNC1numCharCountBits(version:)to return[0, 0, 0]for this modemakeFNC1FirstPosition()The implementation follows the existing code style and design patterns in the library, aiming for consistency and backward compatibility.
Let me know if there are any suggestions or adjustments you'd like — happy to revise if needed!``