Deadly puddles#207
Draft
BrightNibbleston wants to merge 11 commits into
Draft
Conversation
…ze, and to get the coords of it, need to add enitity collision, and add not being able to breathe in if inside puddle with a volume that exceeds DrownU
…ity has it. changed entity detection to use StartCollideEVent and EndCollideEvent to find touching entity, does not give component to entity for unknown reason, remnant code in SharedPuddleSystem.cs in Drowning function remains, remove before pr. also added comment for DrownU detafield in PuddleComponent.cs
… the amount that causes drowning, add comment on drowningu to specify that. works in my testing
|
better have a different "deeper" sprite for the puddle when its in dangerous depths to warn players... ...or i will drown you... irl... |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
|
RSI Diff Bot; head commit c954e77 merging into 76e47ab Resources/Textures/Fluids/deepliquid.rsi
|
did not intend to push these,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
made it possible to drown if a puddle exceeds 200u
Why / Balance
would make liquid based disasters a possibility, and make for some fun interactions, this mechanic will likely not see much use without someone attempting to use it or an artifact released an absurd amount of liquid, or something else
example is this, during messing around on marissa stuff happaned that lead to cargo being flooded with a ton of liqued, creating a puddle that could drown people if my pr was merged
Technical details
added a new component that prevents inhalation called "NotBreathingComponent"
added datafield in PuddleComponent.cs called "DrownU"
added 3 new functions in SharedPuddleSystem.cs called "DrowningInternalsCheck", "DrowningStart" and "DrowningEnd"
"DrowningInternalsCheck" checks if internals are on or off when internals are toggled and adds or remove "NotBreathingComponent" depending on if its turned on or off. Triggers when someone toggles their internals
"DrowningStart" checks for internals being on, if they are not it than checks if the puddle is larger than "DrownU" and applies "NotBreathingComponent" if it is. triggers when someone touches the puddle
"DrowningEnd" just removes "NotBreathingComponent" Triggers when someone steps off the puddle
Test plan
I tested it by filling a room with under and over 200u of liquid and by turning on and off my internals without running into much issue, and leaving myself in the 200u puddle to make sure i drowned properly
Media
no media yet, need to make the sprite and apply it
Requirements
License
MIT
Breaking changes
may cause lag as I haven't ensured "DrowningInternalsCheck" only triggers if the person is touching the puddle and toggles their internals,
ToDo
add a sprite for puddles exceeding 200u
Add movement slow down inside puddle
Changelog
🆑