Skip to content

[Scripts]: Remove --with-deps from tests' postinstall - #968

Merged
emilyhernandez merged 3 commits into
mainfrom
DS-681-remove-with-deps
Aug 5, 2026
Merged

[Scripts]: Remove --with-deps from tests' postinstall#968
emilyhernandez merged 3 commits into
mainfrom
DS-681-remove-with-deps

Conversation

@mfaarni

@mfaarni mfaarni commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

DS-681

The postinstall script for tests folder included --with-deps, which is used to install Playwright's browser libraries. This is a Linux specific command, as MacOS handles the dependencies differently. When running Linux, this caused the npm install command to prompt the user for their password for sudo, but the npm loading spinner obstructed the input field which made the install get stuck.

To my knowledge, the required dependencies are usually already installed. To be sure that even first timers have them, I included a command to install the deps manually in the Getting Started-section of the docs.

Developer's checklist

  • I wrote necessary unit tests
  • I updated Storybook stories and documentation to reflect the latest changes
  • I included visual regression tests for new UI design
  • I tested my implementation with different browsers
  • I checked accessibility according to Web Content Accessibility Guidelines 2.1
  • Together with the reviewer I can confirm that the implementation supports the following screenreader and browser combinations (NVDA + Firefox, VoiceOver + Chrome)

@mfaarni mfaarni added the chore Maintenance and refactoring related issue label Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Lines Statements Branches Functions
Coverage: 94%
94.97% (14137/14885) 89.28% (1425/1596) 91.08% (531/583)
Coverage Report • (94%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files94.9789.2891.0894.97 
report-only-changed-files is enabled. No files were changed in this commit :)

@github-actions
github-actions Bot temporarily deployed to Documentation for branch DS-681-remove-with-deps August 5, 2026 09:35 Destroyed

@emilyhernandez emilyhernandez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well locally 👍

@emilyhernandez
emilyhernandez merged commit 8a6f15a into main Aug 5, 2026
14 checks passed
@emilyhernandez
emilyhernandez deleted the DS-681-remove-with-deps branch August 5, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance and refactoring related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants