[Scripts]: Remove --with-deps from tests' postinstall - #968
Merged
Conversation
mfaarni
requested review from
MayaMarjut,
RiinaKuu,
emilyhernandez,
krisrelax and
moldoc
as code owners
July 23, 2026 07:55
github-actions
Bot
temporarily deployed
to
Documentation for branch DS-681-remove-with-deps
August 5, 2026 09:35
Destroyed
emilyhernandez
approved these changes
Aug 5, 2026
emilyhernandez
left a comment
Contributor
There was a problem hiding this comment.
Seems to work well locally 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DS-681
The postinstall script for tests folder included
--with-deps, which is used to install Playwright's browser libraries. This is a Linux specific command, as MacOS handles the dependencies differently. When running Linux, this caused the npm install command to prompt the user for their password for sudo, but the npm loading spinner obstructed the input field which made the install get stuck.To my knowledge, the required dependencies are usually already installed. To be sure that even first timers have them, I included a command to install the deps manually in the Getting Started-section of the docs.
Developer's checklist