Skip to content

fix(tests): parse appsettings with comments in the CORS configuration tests #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iammukeshm merged 2 commits into from
Nov 3, 2026
Merged

fix(tests): parse appsettings with comments in the CORS configuration tests #1448

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
413b1ab
fix(tests): parse appsettings with comments in the CORS configuration…
maxiar Oct 15, 2026
8ac66fe
Merge branch 'main' into fix/cors-tests-tolerate-appsettings-comments…
iammukeshm Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/Tests/Framework.Tests/Web/CorsConfigurationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ namespace Framework.Tests.Web;

public sealed class CorsConfigurationTests
{
// appsettings files are read by the ASP.NET configuration loader, which accepts comments and
// trailing commas, so parse them the same way.
private static readonly JsonDocumentOptions AppSettingsJson = new()
{
CommentHandling = JsonCommentHandling.Skip,
AllowTrailingCommas = true,
};

[Theory]
[InlineData("appsettings.json")]
[InlineData("appsettings.Production.json")]
Expand All @@ -13,7 +21,7 @@ public void AllowedMethods_Should_IncludePatch_When_RestrictedCorsIsConfigured(s
string path = Path.Combine(AppContext.BaseDirectory, "HostConfiguration", fileName);

// Act
using JsonDocument document = JsonDocument.Parse(File.ReadAllText(path));
using JsonDocument document = JsonDocument.Parse(File.ReadAllText(path), AppSettingsJson);
JsonElement corsOptions = document.RootElement.GetProperty("CorsOptions");
string[] allowedMethods = corsOptions
.GetProperty("AllowedMethods")
Expand Down Expand Up @@ -47,7 +55,7 @@ public void AllowedHeaders_Should_IncludeClientHeader_When_RestrictedCorsIsConfi
string path = Path.Combine(AppContext.BaseDirectory, "HostConfiguration", fileName);

// Act
using JsonDocument document = JsonDocument.Parse(File.ReadAllText(path));
using JsonDocument document = JsonDocument.Parse(File.ReadAllText(path), AppSettingsJson);
string[] allowedHeaders = document.RootElement
.GetProperty("CorsOptions")
.GetProperty("AllowedHeaders")
Expand Down
Loading