Repository navigation
fix(dashboard): welcome the tenant by its name on the overview - #1437
Open
marcelo-maciel wants to merge 1 commit into
Open
marcelo-maciel wants to merge 1 commit into
marcelo-maciel wants to merge 1 commit into
Conversation
The first-run heading and the header caption used the JWT tenant claim, which is the identifier. Read the name from the tenant status query the page already runs, falling back to the identifier while it is unavailable. Fixes fullstackhero#1436
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1436
What changes
The dashboard overview labelled the tenant with
user?.tenant, the JWTtenantclaim, which is the identifier. A tenant with no subscription saw "Welcome to qpb2edshbj" on the first-run card instead of its name, and the header caption ({date} · {tenant}) showed the same identifier.The label now reads
status.data?.namefrom theGET /api/v1/tenants/me/statusquery the page already runs for the "Valid for" card. That query shares its key with the AppShell expiry banner, so it is normally warm when the overview mounts. While the status is loading or failed, the label falls back to the identifier as before, then to "your tenant". No backend change and no new request.Both uses read the same
tenantLabelvariable, so the caption is fixed with the greeting. The identifier is still shown in the top bar's profile menu and in the impersonation banner; those are left as they are.Tests
New Playwright spec in
tests/overview/overview.spec.ts: no subscription (first-run card), status mock names tenantacme"Acme Corp"; asserts the heading is "Welcome to Acme Corp" and that no "Welcome to acme" heading exists.npx playwright test tests/overview/overview.spec.ts→ 1 failed (the new spec, heading rendered "Welcome to acme"), 11 passed.npx tsc -b --noEmit→ exit 0;npm run lint→ 0 errors (12 pre-existing warnings, none in the touched files).expecttimeout while a lazy route compiled for the first time on a cold Vite server (catalog, audits, impersonation-ended); those three specs re-run alone: 18 passed.Rebase note
The dashboard i18n PR #1384 rewrites
overview.tsxinto translation keys. Whichever of the two merges second needs a one-line rebase on thetenantLabelline.