Misc. Fixes - #31
Open
charlot-shaw wants to merge 2 commits into
Open
Conversation
Matches function definition, and other functions defined in the same file.
awkay
reviewed
Feb 6, 2026
| :ident (fn [] session/signup-ident) | ||
| :route-segment ["signup"] | ||
| :componentDidMount (fn [this] | ||
| (comp/transact! this [(session/clear-signup-form)]))} |
Member
There was a problem hiding this comment.
Technically mutations are NOT multi-arity. They are arity 1. Explicit single arg is preferable. In CLJ headless testing using the mutation this way will probably throw. js doesn't care about arity, so it works in CLJS but I don't want to encourage the habit.
Author
There was a problem hiding this comment.
That makes sense, and it's those little details between the platforms that can be very frustrating.
The dummy argument should hopefully improve things.
charlot-shaw
marked this pull request as ready for review
March 2, 2026 04:17
Author
|
Marking this as ready, as life commitments have pulled me elsewhere and I don't think I'll be getting back for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying out the template and making changes that seem like obvious issues.
Thank you for putting this framework together!