Fix AsyncFileSystem._cat_ranges error handling with on_error parameter#2045
Merged
martindurant merged 1 commit intoJun 12, 2026
Merged
Conversation
martindurant
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements error handling for
AsyncFileSystem._cat_rangesby introducing theon_errorparameter (matching theAbstractFileSystem.cat_rangesinterface).Changes:
on_errorparameter toAsyncFileSystem._cat_ranges(defaulting to"return").on_errorin_cat_rangesdocstring.on_erroris not"return", we scan the chunk outputs usingis_exception, raising the first encountered exception.fsspec/tests/test_async.pyverifying both"return"and"raise"behaviors under errors.