Prevent attribute error by checking for 'forced' attribute before flushing cache#2042
Merged
Merged
Conversation
Member
|
Perhaps have |
Contributor
Author
|
Fixed, shall be Okay now. |
TLCFEM
force-pushed
the
tlc/suppress-attr-error
branch
from
59da5d2 to
e840297
Compare
Contributor
Author
|
Looks like early initialization would cause some logical error elsewhere. |
martindurant
reviewed
Jun 1, 2026
Co-authored-by: Martin Durant <martindurant@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a critical bug; however, if a
NotImplementedErroris raised during initialization due to an invalid mode, attributes such as forced are not created.Consequently, subsequent cleanup operations (e.g., close or delete) may raise an
AttributeError.While this exception is typically suppressed, it may still be exposed in some scenarios.
This PR adds safeguards to prevent such cases and avoid unnecessary visual clutter.