fix: sync Cargo.lock and restore crates.io publishing - #17
Open
loispostula wants to merge 2 commits into
Open
Conversation
The release bump changed Cargo.toml only, leaving the lock at 0.5.0. fix-lock-files runs 'cargo update --workspace' and fails on any diff, so every PR opened against master would have failed that presubmit. Signed-off-by: Loïs Postula <lois@postu.la>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
fslabs-bot
Bot
added
the
size/XS
publish = ["fsl"] is cargo's own allowlist, checked before any upload, so it silently narrowed the crate to private-only: 0.6.0 went to fsl while crates.io stayed at 0.5.0, where 0.1.0-0.5.0 are already public. Needs fslabscli#341 to actually take effect; that side could not name the registry legally either. Signed-off-by: Loïs Postula <lois@postu.la>
loispostula
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes, both found while investigating why the 0.6.0 postsubmit did not publish publicly.
1. Cargo.lock was out of sync (urgent)
The 0.6.0 release bumped
Cargo.tomlbut notCargo.lock, which still recordedopd-parser 0.5.0.fix-lock-filesrunscargo update --workspaceand fails on any resulting diff, so every PR opened against master fails that presubmit until this lands:2. crates.io publishing was silently disabled
opd-parseris public on crates.io with 0.1.0 through 0.5.0, none yanked. 0.6.0 went tofslonly, leaving the public crate a version behind.The cause is
publish = ["fsl"], which I added in #16 believingallow_publicin the fslabs metadata was enough. It is not:publishis cargo's own allowlist, checked before any upload:Verified with dry runs that both registries are now permitted:
Note
crates.io(with a dot) is not a legal cargo registry name and cannot be used in this list.Ordering
This alone does not restore public publishing. fslabscli could not name the registry legally either — it built a registry called
crates.io, which cargo rejects, and which also failed its own existence check. That is fslabscli#341.Fix 1 here is independent and worth merging now regardless. Fix 2 takes effect once #341 ships and the prow image picks it up.