Repository navigation
Conversation
sunshine, nomachine, rdp, rustdesk, splashtop, thinlinc carried only an env: allowlist — their config->env mapping lived in eve core's ConfigEnv.MAPPINGS. Move it onto each manifest's config_schema (env_var:), mirroring what the providers already do, so a package owns its config fields and env vars. The linux half declares config_schema for each (it wins the dual-OS merge with the windows half). Release-coupled to the eve-side change (fruwehq/eve#47) that makes ConfigEnv scan package plugins and drops the now-redundant MAPPINGS rows — merge together so no package env var is silently dropped. (moonlight is deliberately not touched: it is sunshine's CLIENT, not a package, and its config + launcher move with the sunshine launcher work — §8.)
Member
Author
|
Superseded by #5 (v4.4 branch) — the §3 package config env_var work is included there along with the rest of v4.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to fruwehq/eve#47 (v4.4 §3). eve core's
ConfigEnv.MAPPINGShard-coded every package's config→env mapping (SUNSHINE_*,THINLINC_*,SPLASHTOP_*,RUSTDESK_SERVER,NOMACHINE_VERSION,RDP_GATE_USER). Move each onto its package manifest'sconfig_schema(env_var:), matching how the providers already declare theirs — so a package owns its config fields and env vars.What
config_schema.configwithenv_vardeclarations to sunshine, nomachine, rdp, rustdesk, splashtop, thinlinc (the linux half — it wins the dual-OS merge with the windows half).string/integer/boolean/path/url/host/enum).Release-coupled
ConfigEnvscan package plugins and drops the now-redundantMAPPINGSrows. Merging core first would silently drop every package env var until this lands.moonlightis deliberately untouched: it is sunshine's client, not a package, and its config + launcher move with the sunshine launcher work (v4.4 §8, still pending).