fix(review): read head check runs, name make verify unconditionally - #253
Merged
Conversation
A reviewer produced a false block on core#118 round 2 because the
minted instructions never told it to read the pull request head's
check runs and let it treat "make verify" as optional ("when it
exists"). Point the pr-review and pr-review-fix instructions, the
review-snowcat-queue skill, and work-queue.md rule 53 at the head's
check runs as the evidence for CI criteria, and require make verify
unconditionally, its absence now a blocker in its own right.
Closes #248
bketelsen
marked this pull request as ready for review
August 25, 2026 00:46
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A reviewer produced a false
blockon frostyard/core#118 round 2 because the mintedpr-reviewinstructions never told it to read the pull request head's check runs, and let it treatmake verifyas optional ("when it exists" / "where it exists") — a missing target is silently skipped instead of flagged.This closes #248 by:
src/queue/pull-request-review.ts: thepr-reviewroot instructions now direct the reviewer to read the head's check runs first (gh pr checks/ commits check-runs API) and treat their conclusions — not the PR description — as the evidence for CI-anchored acceptance criteria;make verifyis now named unconditionally, its absence itself a blocker (defect:makefile:verify-missing). Thepr-review-fixinstructions get the same unconditionalmake verifyand now ask the fixer to check the head's check runs after pushing..agents/skills/review-snowcat-queue/SKILL.md: the "Judge" step gains the same read-the-check-runs rule and unconditionalmake verify; the "Finish" step's evidence bullet now requires the head SHA, each check run's name/conclusion, and the localmake verifyresult.docs/specs/work-queue.mdrule 53: the minted instructions MUST direct the reviewer to the head's check runs as CI evidence and MUST namemake verifyunconditionally (no "where it exists").test/pull-request-review.test.ts: extended the existing minted-instruction-text assertions to requirecheck-runs/gh pr checksand the absence of "when it exists" / "where it exists", for both thepr-reviewandpr-review-fixroots.Risk tier 2 (
src/queue/**steers reviewer behavior but is not itself a governance boundary here).Closes #248
Verification
grep -c 'when it exists\|where it exists' src/queue/pull-request-review.ts .agents/skills/review-snowcat-queue/SKILL.md→0for both.npx tsx --test test/pull-request-review.test.ts→ 19/19 pass, including the two new instruction-text assertions.npm run typecheck→ clean.npm run test:coverage→ 382/382 pass.npm run check:coverage-floors→check-coverage-floors: Node 24 per-file floor(s) met — src/control/store.ts lines 32.2%≥27% funcs 20.81%≥2%; src/queue/store.ts lines 57.31%≥52% funcs 22.5%≥16%npm run check:coverage-denominator→ all 72 src modules present.npm run build→ clean (check-dist,check-bootpass).npm run check:audit,npm run check:docs→ clean.npm run check:deploycould not run:shellcheckis not installed in this sandbox and I have no permission to install packages (apt-get installfails with a dpkg lock permission error). This script is unrelated to the change (only lintsdeploy/**, which this PR does not touch); the check ran clean on the base commit's own CI, and CI here has shellcheck available.