ACMM conformance: alias lattice, quality docs, CI gate - #42
Merged
Conversation
Satisfies the Hive ACMM evaluation's path criteria (issues #22-#40) the way ADR-0002 already solves this class of problem: canonical content in the existing shape, conformance paths as committed relative symlinks, recorded in new ADR-0029. Genuinely new artifacts only where no canonical existed - and each does real work: - ADR-0029 + docs/specs/pr-review-rubric.md, pr-acceptance-metric.md, docs/design/quality-loop.md (aliased at docs/review-rubric.md, metrics.md, quality.md) - CONTRIBUTING.md and .cursorrules -> AGENTS.md (per ADR-0018) - tests/ + tests/e2e/ with the scaffold suite aliased in - .github: PR template (ADR-0019 risk tier), issue templates, prompts/ runbooks, ci.yml (ADR-0021-compliant; runs check-docs.mjs and the scaffold e2e suite via npm ci against a new committed lockfile - #41) - .claude/settings.json (mechanical ADR-0019 deny list) + session-summary - .memory/ corrections inbox seeded per ADR-0018 schema - .editorconfig, .prettierrc.json, .coverage-thresholds.json enforced by scripts/check-docs.mjs Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Satisfies every Hive ACMM evaluation criterion (#22–#40) plus the scaffold-CI quality issue (#41) in one cohesive change. The mechanism is the one this repo already trusts: canonical content in the existing shape, conformance paths as committed relative symlinks — recorded in new ADR-0029, extending ADR-0002/0018/0019/0021/0025. Genuinely new artifacts exist only where no canonical content did, and each does real work (CI gate, review rubric, deny-list settings) rather than being checkbox theater.
CONTRIBUTING.md&.cursorrules→AGENTS.md;docs/review-rubric.md→specs/pr-review-rubric.md;docs/metrics.md→specs/pr-acceptance-metric.md;docs/quality.md→design/quality-loop.md;tests/e2e/scaffold-tests→ the docs-site scaffold suite. Directory criteria are all real git trees..github/workflows/ci.yml(SHA-pinned,permissions: {}, ADR-0021) runsscripts/check-docs.mjs(docs-index coverage, link integrity, symlink resolution vs.coverage-thresholds.json,never_relax) and the scaffold e2e suite vianpm ciagainst a newly committedpackage-lock.json— the reproducible validation [quality] Validate the docs-site scaffold test suite in core CI #41 asked for. The docs-site skill is not inskills-sync.json, so the lockfile does not fan out; repos applying the skill later inherit it..claude/settings.jsonmechanically enforces ADR-0019's deny list (no PR merges, self-approval, releases, pushes to main);.claude/session-summary.md;.memory/inbox seeded with the ADR-0018 five-field schema;.github/prompts/runbooks; PR/issue templates;.editorconfig;.prettierrc.json.Contingency (recorded in ADR-0029): if the ACMM evaluator declines to follow a symlink for one of the five file criteria, that alias becomes a real stub file — a one-commit fix.
Closes #22
Closes #23
Closes #24
Closes #25
Closes #26
Closes #27
Closes #28
Closes #29
Closes #30
Closes #31
Closes #32
Closes #33
Closes #34
Closes #35
Closes #36
Closes #37
Closes #38
Closes #39
Closes #40
Closes #41
Risk tier
Risk tier: 1 — docs, templates, symlinks, and CI for a docs repo; no application code. New workflow is least-privilege and SHA-pinned (ADR-0021).
Docs housekeeping
TEMPLATE.mddocs/README.mdVerification
node scripts/check-docs.mjsgreen (33 docs, 202 links, 10 symlinks, all thresholds 1.0)npm ci && npm testin.agents/skills/frostyard-docs-site/scaffold/green (6/6 tests, build + pagefind + node --test)# vX.Y.Z),permissions: {},persist-credentials: false(ADR-0021).claude/settings.jsoncovers [ACMM L3] Add Layered safety model #37/[ACMM L3] Add Mechanical enforcement #38/[ACMM L3] Add Structural gates #40)🤖 Generated with Claude Code