ci(organization): require the Makefile gate triad in every repository (ADR-0044) - #126
Merged
Merged
Conversation
… (ADR-0044) Drop the Node/Go branch from fleet-conventions.mjs (core#118): every enabled declaration now needs Makefile verify/check/ci targets plus mise.toml/mise.lock, with no per-language detection. Closes #125. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
bketelsen
marked this pull request as draft
August 25, 2026 01:14
bketelsen
marked this pull request as ready for review
August 25, 2026 01:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go.mod/package.jsonper-language branch fromcheckRepositoryinscripts/lib/fleet-conventions.mjs. Everyfleet_state: "enabled"declaration now requiresmise.toml(with[tools]), a non-emptymise.lock, and a rootMakefilewithverify:,check:, andci:targets — presence only, per ADR-0044.scripts/check-fleet-conventions.mjsneeded no change; the branch lived entirely infleet-conventions.mjs.package.jsonbut no Makefile fails naming Makefile", and adds a Makefile to the existing conformant-Node fixture so it still passes. Keeps the Go case, missing-mise.lock case, missing-verify: case, and disabled-declaration case.docs/design/quality-loop.mdVerify bullet ("Gate (fleet Go repositories)" → "Gate (fleet repositories)", removes "(Go only in go.mod)").AGENTS.md'scheck:fleetline doesn't namepackage.json, so it needed no edit.Closes #125.
Test plan
grep -cE 'package\.json|go\.mod' scripts/lib/fleet-conventions.mjs scripts/check-fleet-conventions.mjs→0for both files.node --test test/fleet-conventions.test.mjs→ 5/5 pass.npm run check(make ci) → docs, organization, and scripts checks pass; fleet-conventions unit tests pass. (Thesync-skills-containmentsuite fails locally only because this sandbox lacksrsync; confirmed pre-existing and unrelated by reproducing on the unmodified branch.)Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com