build: add a Makefile exposing the verify/check/ci gate triad (ADR-0044) - #121
Merged
Conversation
Resolves #120. Adds a root Makefile wrapping the existing npm scripts (verify, check, ci) so make verify/check/ci work at the repository root, the only entry points CI, workers, reviewers, and the organization gate invoke per ADR-0044. Points docs-gate's CI step at make ci and documents the wrapper in AGENTS.md and the onboard-repo skill's audit bullet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #120.
Makefilewithverify,check, andcitargets (each wraps the like-named npm script),.PHONY: verify check ci,SHELL := /usr/bin/env bash. No other targets — the npm scripts remain the implementation..github/workflows/ci.yml: thedocs-gatejob's gate step now runsmake ciinstead ofnpm run check(one line change;npm ci, SHA pins,permissions: {},persist-credentials: false, and thefleet-conventions/scaffold-e2ejobs are unchanged).AGENTS.md"Code conventions": documentsmake verify/make check/make cias the entry points CI, workers, reviewers, and the organization gate invoke (ADR-0044), wrapping the like-named npm scripts..agents/skills/frostyard-onboard-repo/SKILL.mdstep 2 audit bullet: the canonical-surfaces bullet now also names a rootMakefilewithverify/check/citargets (ADR-0044).This lands ADR-0044, which core#118's round-2 review incident cited (a reviewer ran
make verifyhere and gotNo rule to make target 'verify').Risk tier
Touches
.github/workflows/**, whichpolicies/agent-governance.json'sworkflow-and-permissionsboundary marksreview-requiredatminimum_risk_tier: high. Declaring this PR at that tier — a human needs to mark it ready for review.Verification
grep -cE '^(verify|check|ci):' Makefile→3grep -c 'run: make ci' .github/workflows/ci.yml→1grep -c 'run: npm run check$' .github/workflows/ci.yml→0node scripts/check-docs.mjs→ green (ok docs_index_coverage,ok link_integrity,ok symlink_resolution; 58 docs, 429 links, 10 symlinks)make verifyon a clean checkout (afternpm ci):check:docs,check:organization,check:scriptsall green;npm testis 24/26 passing — the 2 failures (sync-skills-containment.test.mjs) arersync: command not foundin this local sandbox only (norsyncbinary present here), not caused by this change; unrelated to the Makefile/CI/docs edits in this PR.git status --porcelainafter the run shows only this PR's own diff — no side effects from runningverify.make ciruns and is green on this head;fleet-conventionsandscaffold-e2eare untouched by this change and expected to stay green.