pin foundry to v1.7.1 in contracts CI#49
Merged
Merged
Conversation
Unpinned nightly started emitting a version-suffixed VmContractHelper artifact that trips the clean-tree check after build. Pin to the same stable release used locally so committed ABIs stay reproducible. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contracts CI has been red on every push since March because it installs unpinned Foundry
nightly: a recent nightly emits a syntheticout/MockProject.t.sol/VmContractHelper50.abi.jsonartifact duringforge build, which trips the clean-tree-after-build check (the50is version-suffixed, so committing it would just break again on the next nightly).Local forge
v1.7.1(stable) produces a clean tree against the committed ABIs, so this pins CI to that same release — reproducible builds, and CI stops breaking on upstream nightly changes. Also updates the action tofoundry-rs/foundry-toolchain(theonbjergpath is the old pre-move location).The contracts run on this PR is the verification.
🤖 Generated with Claude Code