docs(solutions): committed-bundle attribution + SBOM hygiene#979
Open
marcusrbrown wants to merge 1 commit into
Open
docs(solutions): committed-bundle attribution + SBOM hygiene#979marcusrbrown wants to merge 1 commit into
marcusrbrown wants to merge 1 commit into
Conversation
Document the reusable lessons from making the bundled dist/ third-party license notice deterministic and intentionally tracked: if the bundle is committed, the attribution is committed too (verify it under the same dist-sync gate rather than exempting it); generate deterministically so the gate is the reproducibility proof; fail closed on a total license-collection failure but not on benign per-dependency gaps; Renovate ignorePaths is a scan exclusion, not a commit filter; and ship the CycloneDX SBOM as a non-blocking CI artifact separate from the human-readable notice. Cross-links the harness-base-version (remove-the-exception meta-rule) and gateway-docker (build-time-invariant + CI self-check) sibling docs both ways.
fro-bot
approved these changes
Jun 21, 2026
fro-bot
left a comment
Owner
There was a problem hiding this comment.
Verdict: PASS
Docs-only change: adds one workflow-issue solution doc (committed-dist-attribution-and-sbom-hygiene-2026-06-21.md) and two one-line bidirectional cross-links into sibling docs. No source, dist/, test, or public-API surface is touched, so there is no runtime regression or security exposure.
I verified the load-bearing technical claims against the live repo rather than taking the doc at face value:
- All five cross-linked targets resolve (
harness-base-version,cross-libc-build-and-release-safety,versioned-tool-config-plugin-pattern,gateway-docker-runtime-resolution-crash-loop,tool-binary-caching-ephemeral-runners), and the two sibling edits make the linkage bidirectional. .github/renovate.json5matches the doc:ignorePaths: ['dist/**'],postUpgradeTasks.commands: ['pnpm install', 'pnpm run build', 'pnpm run fix'],executionMode: 'branch'..github/workflows/ci.yamldist-diff gate matches the quoted snippet (git diff --ignore-space-at-eol dist/), confirming the "unconditional gate, no renovate carve-out" framing.- Frontmatter schema (
title,date,problem_type,component,severity,applies_when,tags) is consistent with the sibling workflow-issue doc.
Blocking issues
None
Non-blocking concerns
- Rule 6's
actions/upload-artifact@...and thepnpm sbomredirect example are illustrative pseudo-snippets (pinned-SHA elided). Since the SBOM lane is described as aspirational guidance rather than landed CI, this is fine as documentation, but a reader should not copy the@...literally. - The doc references
dist/THIRD_PARTY_NOTICES.txtas the target name; if PR #978 actually landed a different filename, a future reader cross-checking the tree should confirm. Not blocking — this doc captures the lesson, not the canonical config.
Missing tests
None — documentation-only; no behavior to cover. The doc itself argues (correctly) that the dist-diff gate is the reproducibility proof, so no new test is warranted.
Risk assessment (LOW): Docs-only, additive, no executable paths. Regression likelihood negligible; no security exposure; blast radius limited to the docs tree. All referenced links and config claims verified against the repository.
Run Summary
| Field | Value |
|---|---|
| Event | pull_request |
| Repository | fro-bot/agent |
| Run ID | 27915839762 |
| Cache | hit |
| Session | ses_114384feeffedfdmqSKXhwBqKK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures the reusable lessons from PR #978 (deterministic, committed third-party notices + CI SBOM) as a workflow-issue solution doc, and cross-links it into the build/release doc family.
New doc
docs/solutions/workflow-issues/committed-dist-attribution-and-sbom-hygiene-2026-06-21.md— seven rules:ignorePathsis a scan exclusion, not a commit filter — Renovate'spostUpgradeTasksalready rebuilds dist, which is what makes removing the carve-out safe.pnpm sbom), separate from the human-readable notice.Cross-links
Bidirectional with the closest siblings: harness-base-version (the remove-the-exception meta-rule) and gateway-docker (the build-time-invariant + CI-self-check pattern), plus one-way links to the fail-closed canon, Renovate/versioned-tool, and dist-rebuild-verification docs.
Docs-only; no source or
distimpact.