Infographics: five pages, WebP conversion, sidebar group icons#4
Merged
Merged
Conversation
The 30 uploaded PNGs came to 82 MB, several of them 5-6 MB each, which is more than the rest of the site put together. Converted to WebP at a 2000px cap and quality 85 — 4.7 MB total, and legible at full size, which is what matters for images this dense. The PNGs are removed; git history has them. Split across four pages rather than one, with an index in front: infographics.md the four pages, and a note on using them elsewhere infographics-ai.md 8 — what a model is, weights, the improvement loops infographics-tools.md 10 — terminal, Git, Node, databases, hosting infographics-method.md 9 — this repository, drawn infographics-portfolio.md 3 — the programme layer Build changes: - A line that is only an image now renders as a figure with the alt text as its caption, rather than a paragraph with a picture in it. One thing to write, and no way to caption an image while leaving it unreadable to a screen reader. - linkFor resolves web/infographics/* to the copied site path. Without this it returned a GitHub blob URL, which gives an <img> a web page rather than an image — and it would only have failed once the site was published. - The folder is copied into _site/, and a sweep after the copy fails the build on any image no page shows. An unreferenced 200 KB file ships and is seen by nobody, and there is no later moment when anyone would notice. Sidebar groups now carry an icon. .nav-link was already a flex row with a gap, so this only needed the same treatment on .sidebar-title. Raster figures fit the column and open at full size on click, which is the opposite of what the inlined SVG diagrams do — those scroll sideways because they can be scaled without loss and these cannot.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (30)
📒 Files selected for processing (38)
📝 WalkthroughWalkthroughAdded four infographic documentation pages, an index, and a collection of WebP assets. Extended the site generator with infographic navigation, image rewriting, zoomable figures, asset copying, and unreferenced-asset validation. ChangesInfographics publishing
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 30 uploaded PNGs came to 82 MB, several of them 5-6 MB each, which is more than the rest of the site put together. Converted to WebP at a 2000px cap and quality 85 — 4.7 MB total, and legible at full size, which is what matters for images this dense. The PNGs are removed; git history has them.
Split across four pages rather than one, with an index in front:
infographics.md the four pages, and a note on using them elsewhere
infographics-ai.md 8 — what a model is, weights, the improvement loops
infographics-tools.md 10 — terminal, Git, Node, databases, hosting
infographics-method.md 9 — this repository, drawn
infographics-portfolio.md 3 — the programme layer
Build changes:
Sidebar groups now carry an icon. .nav-link was already a flex row with a gap, so this only needed the same treatment on .sidebar-title.
Raster figures fit the column and open at full size on click, which is the opposite of what the inlined SVG diagrams do — those scroll sideways because they can be scaled without loss and these cannot.
Summary by CodeRabbit
New Features
Documentation
Style