feat: Next 16.3 offline banner, Better Auth rc.4 accountId - #65
Conversation
📦 Bumped Next 16.3.0, Better Auth rc.4, Panda beta.12, nuqs 2.9.5, Ultracite 7.10.1 ✨ Added OfflineBanner via experimental useOffline in navbar 🔐 Migrated account.providerAccountId back to accountId for Better Auth rc.4 🐛 Set appearance base-select on picker for customizable select 📝 Synced README badges, structure, and auth schema notes 🔧 Cleared bunfig release-age excludes, refreshed audit overrides
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
React Doctor found no new issues. 🎉 Reviewed by React Doctor for commit |
PR Summary by QodoUpgrade to Next 16.3, add offline banner, and align Better Auth accountId
AI Description
Diagram
High-Level Assessment
Files changed (13)
|
Code Review by Qodo
1. Navbar spacing regression
|
| /> | ||
| </div> | ||
| </Link> | ||
| <OfflineBanner /> |
There was a problem hiding this comment.
1. Navbar spacing regression 🐞 Bug ≡ Correctness
Navbar now renders OfflineBanner as a third direct child inside the between() container; when offline on md+, that extra flex item can redistribute spacing and shift the nav/auth group away from its prior alignment.
Agent Prompt
## Issue description
`<nav className={between()}>` previously had two “endpoints” (logo on the left, nav/auth on the right). This PR inserts `<OfflineBanner />` as a third direct child, which can change how the `between()` layout distributes space when the banner is visible (offline, `md+`).
## Issue Context
The banner is a client component that renders a visible `<div>` only when offline and only at `md+` (it’s `display: none` at base). When it renders, it becomes an additional layout sibling between the logo and the nav list.
## Fix Focus Areas
- src/components/navbar/navbar.tsx[41-96]
## Suggested fix
Preserve a two-child structure for the `between()` container by grouping the banner together with the existing nav/auth content, e.g.:
- Keep: child #1 = logo/link
- Make: child #2 = wrapper `<div className={hstack(...)}>` containing `<OfflineBanner />` and the `<ul>`
This keeps the high-level layout stable while still showing the offline indicator.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Summary
📦 Bumped Next 16.3.0, Better Auth rc.4, Panda beta.12, nuqs 2.9.5, Ultracite 7.10.1
✨ Added OfflineBanner via experimental useOffline in navbar
🔐 Migrated account.providerAccountId back to accountId for Better Auth rc.4
🐛 Set appearance base-select on picker for customizable select
📝 Synced README badges, structure, and auth schema notes
🔧 Cleared bunfig release-age excludes, refreshed audit overrides
Closes #37
Closes #63
Test plan
bun run db:migrateappliesbetter_auth_rc4_account_id(provider_account_id → account_id)<select>picker styles withappearance: base-selectbun auditclean;bun run type/bun run checkpass