refactor(sentry): replace manual flush with context lifecycle management#1070
Draft
huangdijia wants to merge 15 commits into
Draft
refactor(sentry): replace manual flush with context lifecycle management#1070huangdijia wants to merge 15 commits into
huangdijia wants to merge 15 commits into
Conversation
- Remove SentrySdkAspect (AOP interception for SentrySdk init/hub/context) - Use SentrySdk::startContext()/endContext() in CoroutineAspect - Remove all manual SentrySdk::flush() calls from Metrics listeners (OnBeforeHandle, OnCoroutineServerStart, OnMetricFactoryReady, OnWorkerStart, PoolWatcher, QueueWatcher) - Remove SentrySdk::flush() from Tracing CoroutineAspect and EventHandleListener - Unregister SentrySdkAspect from ConfigProvider
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ext" This reverts commit fd289ca.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor Sentry integration to use
SentrySdk::startContext()/endContext()for coroutine context management, replacing the previous pattern of manualSentrySdk::flush()calls scattered across the codebase.Background
The previous implementation manually called
SentrySdk::flush()in multiple listeners and aspects after each operation. Additionally,SentrySdkAspectinterceptedSentrySdkmethods via AOP to manage coroutine-safe hub/context state. This approach was fragile and scattered flush logic across many files.Changes
SentrySdkAspect— Remove AOP interception ofSentrySdk::init,setCurrentHub,getRuntimeContextManagerCoroutineAspectrefactor — UseSentrySdk::startContext()before coroutine starts andSentrySdk::endContext()on defer, replacing the oldSentrySdk::flush()patternSentrySdk::flush()calls from:Metrics/Listener/OnBeforeHandleMetrics/Listener/OnCoroutineServerStartMetrics/Listener/OnMetricFactoryReadyMetrics/Listener/OnWorkerStartMetrics/Listener/PoolWatcherMetrics/Listener/QueueWatcherTracing/Aspect/CoroutineAspectTracing/Listener/EventHandleListenerSentrySdkAspectfromConfigProviderTest Plan
Risks
startContext()/endContext()APIs must be available in the target Sentry SDK version. Verify compatibility before merging.