Skip to content

chore: remove dependency on reap, use namespace Reap.TreeSearch - #1

Merged
slashbade merged 5 commits into
mainfrom
feat/no-reap-dep-with-namespace
Feb 17, 2026
Merged

chore: remove dependency on reap, use namespace Reap.TreeSearch#1
slashbade merged 5 commits into
mainfrom
feat/no-reap-dep-with-namespace

Conversation

@jzxia

@jzxia jzxia commented Feb 15, 2026

Copy link
Copy Markdown
Contributor

@slashbade already removed dependency on reap.

On top of that, this PR moves all names except proofSearchBFS into namespace Reap.TreeSearch to avoid conflicts with Mathlib.

Details:

  • At least one conflict is confirmed: bestFirstSearch in TreeSearch/Abstract/BestFirst.lean is already defined in Mathlib.Deprecated.MLList.BestFirst.
  • For now, proofSearchBFS is exposed to the root namespace so that we don't need to make any changes in the reap repository. In the future, we may want to move it to a more appropriate namespace.

slashbade and others added 5 commits February 6, 2026 17:17
…eeSearch` to avoid conflicts with Mathlib.

- At least one conflict is confirmed: `bestFirstSearch` in `TreeSearch/Abstract/BestFirst.lean` is already defined in `Mathlib.Deprecated.MLList.BestFirst`.
- For now, `proofSearchBFS` is exposed to the root namespace so that we don't need to make any changes in the reap repository. In the future, we may want to move it to a more appropriate namespace.
…use in this branch, there should be no dependence on reap)
@jzxia jzxia changed the title chore: use namespace Reap.TreeSearch, remove dependency on reap chore: remove dependency on reap, use namespace Reap.TreeSearch Feb 15, 2026
@slashbade
slashbade merged commit f294398 into main Feb 17, 2026
2 checks passed
@tonyxty
tonyxty deleted the feat/no-reap-dep-with-namespace branch March 30, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants