fix: add makefile check - #2863
Open
sven-urbanski-freiheit-com wants to merge 1 commit into
Open
Conversation
in order to verify that IMAGE_TAG_KUBERPULT is set when running helm tests Ref: SRX-ISPEFN
bqcuong
reviewed
Apr 13, 2026
|
|
||
| test-helm: $(TGZ_FILE) Chart.yaml | ||
| check-precondition: | ||
| @if [ -z "$(IMAGE_TAG_KUBERPULT)" ]; then echo "IMAGE_TAG_KUBERPULT not set, exiting"; exit 1; fi |
Contributor
There was a problem hiding this comment.
Why and when would the IMAGE_TAG_KUBERPULT be empty? Can we fix the root cause of this issue?
If this happens in the CI builds, we do not want empty IMAGE_TAG_KUBERPULT, otherwise, the builds will be failing, right?
Contributor
Author
There was a problem hiding this comment.
The CI sets it, and it works there.
I added this check so that we get a quicker and clearer error when running locally. Locally we have to set the tag manually.
Contributor
There was a problem hiding this comment.
For local, is it possible to leverage the existing make version target to get IMAGE_TAG_KUBERPULT? Manual configuration seems a bit unnecessarily complex.
bqcuong
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in order to verify that IMAGE_TAG_KUBERPULT is set when running helm tests
Ref: SRX-ISPEFN