fix: prevent multiple file/folder dialogs from opening simultaneously [0x954dB727D3b1d1C736A5C15b480bC2bFB3c8Ee63] - #2414
Open
waterWang wants to merge 1 commit into
Conversation
Add a guard to the openPathPickingDialog injectable so that only one file/folder selection dialog can be open at a time. When a dialog is already open, subsequent calls are ignored until it closes. Also disable the PathPicker button while a dialog is open to provide visual feedback and prevent accidental repeated clicks. Fixes freelensapp#1850
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When clicking the + button in the Clusters Catalog (or any path-picking button) multiple times quickly, multiple file/folder selection dialogs open simultaneously. This creates a confusing UX.
Changes
Fixes
Fixes #1850