[Integration tests] 'Roles' pages#1133
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @carma12, your pull request is larger than the review limit of 150000 diff characters
veronnicka
left a comment
veronnicka
left a comment
There was a problem hiding this comment.
Hi, went through the steps, just have a comment regarding test scenarios with the state of the buttons. As I recall we didnt test this in other tests, it is a behaviour that is the same across the subpages. At least this is my understanding, please correct me if im wrong.
| Given role "button_state_role" exists | ||
|
|
||
| @test | ||
| Scenario: Save and Revert buttons are disabled when no changes |
There was a problem hiding this comment.
Same as my other comment.
There was a problem hiding this comment.
I considered leaving this one here (although we don't have it in other 'Settings'-related tests) because I have seen that sometimes those buttons tend to not be enabled/disabled properly when a change is done. Not really necessary or critical, but it is open to discussion whether we want to keep it or not.
Just to provide more context: All 'Settings' pages have three main buttons: 'Refresh', 'Revert', and 'Save'. By default, the 'Revert' and 'Save' buttons are disabled. When something is modified in the 'Settings' page (e.g., I change the description field or any other field), those buttons are enabled and ready to be clicked. This is the only scenario on which we want to have those buttons enabled, and not when no modification has been done.
There was a problem hiding this comment.
Im fine with keeping it then.
5f0115c to
c4fa964
Compare
carma12
added
needs-review
veronnicka
left a comment
veronnicka
left a comment
There was a problem hiding this comment.
Changes look good, feel free to merge after the rebase and when the checks pass.
| Given role "button_state_role" exists | ||
|
|
||
| @test | ||
| Scenario: Save and Revert buttons are disabled when no changes |
There was a problem hiding this comment.
Im fine with keeping it then.
The integration tests must test the functionality of the Roles' following pages: - Main page - 'Settings' page - 'Members' page - 'Privileges' page Assisted-by: Claude <noreply@anthropic.com> Signed-off-by: Carla Martinez <carlmart@redhat.com>
c4fa964 to
3d5c524
Compare
|
Rebased and waiting for the tests to finish before merging... |
3 participants
The integration tests must test the functionality
of the Roles' following pages:
This PR has been created on the top of #1132 , so it must be merged first.