bhyve: add binary memory writes to GDB stub - #2413
Open
peripherium wants to merge 1 commit into
Open
Conversation
Add support for the GDB remote protocol X packet to the bhyve GDB stub, allowing memory to be written using binary data in addition to the existing M packet. Signed-off-by: Manuel Einfalt <einfalt1@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements one of the remaining TODOs in the bhyve GDB stub.
Currently, memory writes are only supported through the
Mpacket, which sends the data as hexadecimal. With this change, the stub also handles theXpacket from the GDB remote protocol, allowing GDB to use binary memory writes when binary downloads are enabled.This makes
set remote binary-download onusable with the bhyve GDB stub.