Skip to content

rm(1): guard against accidental removal of /* and /dev #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZhangQiyue2011 wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −0
Open

rm(1): guard against accidental removal of /* and /dev #2381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions bin/rm/rm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ static int check(const char *, const char *, struct stat *);
static int check2(char **);
static void checkdot(char **);
static void checkslash(char **);
static void checkhazard(char **);
static void rm_file(char **);
static void rm_tree(char **);
static void siginfo(int __unused);
Expand Down Expand Up @@ -141,6 +142,7 @@ main(int argc, char *argv[])

checkdot(argv);
checkslash(argv);
checkhazard(argv);
uid = geteuid();

(void)signal(SIGINFO, siginfo);
Expand Down Expand Up @@ -444,6 +446,31 @@ checkslash(char **argv)
}
}

/*
* Block removal of root-asterisk or /dev to
* prevent catastrophic system damage; added
* by Zhang Qiyue.
*/
/* Match literal "/dev", also matches root‑asterisk argument */
#define ISDEV(a) (strcmp((a), "/dev") == 0)
/* Match literal "/dev/", also matches root‑asterisk‑slash argument */
#define ISDEVSLASH(a) (strcmp((a), "/dev/") == 0)
static void
checkhazard(char **argv)
{
char **t;

for (t = argv; *t; ++t) {
if (ISDEV(*t)) {
errx(1, "/* or /dev may not be removed; "
"aborting entire removal");
} else if (ISDEVSLASH(*t)) {
errx(1, "/*/ or /dev/ may not be removed; "
"aborting entire removal");
}
}
}

static int
check2(char **argv)
{
Expand Down
Loading