Add kmod support on FreeBSD - #186
Merged
Merged
Conversation
This change improves direct code coverage in this area; other testcases may have previously exercised these code paths but this improves code coverage by adding tests to explicitly exercise these APIs. Reported by: lcov Signed-off-by: Enji Cooper <ngie@FreeBSD.org>
This change adds kmod querying support for FreeBSD, allowing tests to require specific kmods using the `require.kmods` metadata in testcases, or the `atf_require_kmod` function in atf-c(3), atf-c++(3), and atf-sh(1). This functionality has been stubbed out and is expected to fail/not be available on all other OSes, e.g., Linux, macOS, etc. A corresponding paired change is required in order to make this functionality work with kyua. That change is coming soon. This is a forward port of kmod support from [freebsd/atf@83a1ee57][1]. The original implementation was by Dag-Erling Smørgrav. Co-Authored By: Dag-Erling Smørgrav <das@FreeBSD.org> Signed-off-by: Enji Cooper <ngie@FreeBSD.org> [1]: https://cgit.freebsd.org/src/commit/?id=83a1ee578c9d1ab7013e997289c7cd470c0e6902
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds kmod querying support for FreeBSD, allowing tests to
require specific kmods using the
require.kmodsmetadata in testcases,or the
atf_require_kmodfunction in atf-c(3), atf-c++(3), andatf-sh(1).
This functionality has been stubbed out and is expected to fail/not be
available on all other OSes, e.g., Linux, macOS, etc.
A corresponding paired change is required in order to make this
functionality work with kyua. That change is coming soon.
This is a forward port of kmod support from [https://github.com/freebsd/atf/commit/83a1ee57][1]. The
original implementation was by Dag-Erling Smørgrav.
Co-Authored By: Dag-Erling Smørgrav das@FreeBSD.org
Signed-off-by: Enji Cooper ngie@FreeBSD.org
[1]: https://cgit.freebsd.org/src/commit/?id=83a1ee578c9d1ab7013e997289c7cd470c0e6902