SPDX license identifiers to atf-c - #128
Open
illuusio wants to merge 1 commit into
Open
Conversation
Add BSD-2-Clause identifiers to atf-c to C-source and header files Sponsored by: The FreeBSD Foundation Signed-off-by: Tuukka Pasanen <tuukka.pasanen@ilmi.fi>
illuusio
changed the title
illuusio
changed the title
illuusio
changed the title
ngie-eign
requested changes
Aug 13, 2026
Contributor
There was a problem hiding this comment.
This change actually breaks the BSD-2-Clause text.
Please put the SPDX ID on its own line outside the body of the licensing text, e.g.,
/* Copyright (c)...
* All rights reserved.
* ...
* IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */
/** SPDX-License-Identifier: BSD-2-Clause **/
I could make a similar change, but if you're interested in doing this (for licensing mining reasons), I'm more than happy to have you lead this effort.
Member
How so? SPDX tags merely need to be in a comment near the top of the file. |
Author
|
Yes I can make needed changes but I have bit similar view than @emaste that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BSD-2-Clause identifiers to atf-c to C-source and header files. This does not comply FreeBSD
style(9)guidance.