feat: replace unmaintained netifaces dependency with psutil - #141
Open
fredrike wants to merge 2 commits into
Open
feat: replace unmaintained netifaces dependency with psutil#141fredrike wants to merge 2 commits into
fredrike wants to merge 2 commits into
Conversation
netifaces is archived and unmaintained, with no fixes for Python 3.14. Replace its only use in the discovery module (enumerating IPv4 interface broadcast addresses) with psutil, which is actively maintained and cross-platform. Drop netifaces from dependencies and CI configs, and add unit tests covering broadcast selection and discovery message handling.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
==========================================
+ Coverage 85.60% 86.63% +1.02%
==========================================
Files 12 12
Lines 1341 1339 -2
==========================================
+ Hits 1148 1160 +12
+ Misses 193 179 -14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117
netifacesis archived and unmaintained, with open bugs against Python 3.14 and no plan to fix them. This PR replaces its only use withpsutil, which is actively maintained and cross-platform.Changes
psutil.net_if_addrs()instead ofnetifaces(same resulting addresses, cross-platform).netifacesforpsutil.netifacespylint extension allow-list entries.ip=override, device parsing, stop-on-name, and invalid-response handling.Verification
pre-commit run --all-filespasses (ruff + pylint).