Add new skyfi hot water appliances - #114
Open
billgeo wants to merge 4 commits into
Open
Conversation
Add DaikinAirBaseHotWater for BRP15B61/AirBase hot water systems using the local /skyfi/hotwater API. Wire the device into factory detection and the CLI, including explicit hot water controls for power, boost, vacation mode, vacation days, and boil level. Add async tests for status parsing, validation, setter requests, factory detection, and AirBase fallback behavior.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
==========================================
+ Coverage 84.04% 84.78% +0.74%
==========================================
Files 12 13 +1
Lines 1178 1564 +386
==========================================
+ Hits 990 1326 +336
- Misses 188 238 +50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
billgeo
marked this pull request as ready for review
May 2, 2026 10:42
Owner
|
Please update tests to covered changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thanks for the opportunity to contribute! 😄
Adds support for Daikin RQWX60ZV1A (C02 heat pump hot water system) that uses the Daikin Airbase BRP15B61 Controller.
This introduces a dedicated
DaikinAirBaseHotWaterdevice for the local/skyfi/hotwater/...API, with status parsing, typed status helpers, control setters, and local validation before writes. It is integrated withDaikinFactorythrough auto-detection orhot_water=True, and exposed in the CLI via--hot-water.The hot water implementation is kept separate from the existing SkyFi/aircon protocol so current device behavior should be unaffected.
Tests added for parsing, validation, setters, and factory detection.
Test summary for scripts I ran on a local Daikin RQWX60ZV1A / BRP15B61 system:
Type of Change
Testing
Code Quality
pre-commit run --all-files)String Formatting (New Code)
") for strings following Python conventionsDocumentation
Related Issues
As described in #112
Additional Notes