fix(og): title generated cards with the page title, not meta_title#723
Merged
Conversation
meta_title is SEO copy for the search-result snippet, often keyword-padded and suffixed with a site name; the card is a visual label for the page you are about to open. Also grows the space logo from 100px to 132px so it holds its weight at feed scale, and bumps TEMPLATE_VERSION to invalidate every cached card. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dn1ETNV7ufoM8xA6FCLnnE
Confidence Score: 5/5The PR appears safe to merge. The title remains mandatory on every production path, and the template change is covered by cache invalidation with no concrete failure identified. Reviews (1): Last reviewed commit: "fix(og): title the card with the page ti..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The auto-generated OG card titled itself with
meta_title or title.meta_titleis SEO copy written for the search-result snippet — usually keyword-padded and suffixed with a site name — so the card read wrong as a visual label for the page.Solution
title.TEMPLATE_VERSIONbumped to 4 — it is a fingerprint input, so every cached card invalidates itself. No manual purge needed.Unit test added (
test_card_title_ignores_meta_title), verified against a temp revert of the fix.🤖 Generated with Claude Code
https://claude.ai/code/session_01Dn1ETNV7ufoM8xA6FCLnnE