feat: send reader's Edit button straight to GitHub for synced spaces#706
Open
NagariaHussain wants to merge 3 commits into
Open
feat: send reader's Edit button straight to GitHub for synced spaces#706NagariaHussain wants to merge 3 commits into
NagariaHussain wants to merge 3 commits into
Conversation
…spaces Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012PXJnZXUyt5vyE7DiuLnD3
The public page's Edit button pointed at the wiki editor, which is read-only for git-synced spaces. It now opens the page's source file in GitHub's web editor (new tab), matching the editor-side "Edit on GitHub" action. Folder-only groups have no editable source, so they keep the Copy button as the primary action. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012PXJnZXUyt5vyE7DiuLnD3
Confidence Score: 5/5Safe to merge — the change is well-scoped and non-synced spaces are completely unaffected. All changed paths are guarded by the git_synced flag, fallback behaviour for normal spaces is unchanged, and the unit tests verify both the happy path and the folder-group edge case. No files require special attention. Reviews (2): Last reviewed commit: "refactor: build GitHub edit URL from the..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Review feedback (greptile): _can_show_edit re-resolved the space via get_edit_link even though get_web_context passes wiki_space_doc in. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012PXJnZXUyt5vyE7DiuLnD3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the public reader page of a git-synced space, the Edit button links to the wiki editor — which is read-only for synced spaces, so it's a dead end.
Solution
For git-synced spaces, the reader's Edit button now says "Edit on GitHub" and opens the page's source file in GitHub's web editor (new tab) — same URL the editor-side three-dots action uses. Folder-only groups have no editable source file, so they keep Copy as the primary action. Non-synced spaces are unchanged.
Unit tests included (temp-revert verified).
🤖 Generated with Claude Code
https://claude.ai/code/session_012PXJnZXUyt5vyE7DiuLnD3