fix: don't save -> write page on load#202
Merged
Merged
Conversation
ruchamahabal
marked this pull request as ready for review
July 22, 2026 16:53
Contributor
Confidence Score: 5/5The latest changes look safe to merge.
Reviews (2): Last reviewed commit: "fix: don't save -> write page on load" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
- onActivated check + immediate watcher on pageID led to 2 setPage calls. The second one's setRootBlock was treated as an edit because first one was finished by then and settingPage was false so it treated the second setRootBlock as page dirty and saved -> exported page file
ruchamahabal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onActivated check + immediate watcher on pageID led to 2 setPage calls. The second one's setRootBlock was treated as an edit because first one was finished by then and settingPage was false so it treated the second setRootBlock as page dirty and saved -> exported page file