Skip to content

fix: allow moving a block inside a slot and deleting a slot from layers panel#201

Merged
ruchamahabal merged 3 commits into
frappe:developfrom
ruchamahabal:fix-slot-move
Jul 22, 2026
Merged

fix: allow moving a block inside a slot and deleting a slot from layers panel#201
ruchamahabal merged 3 commits into
frappe:developfrom
ruchamahabal:fix-slot-move

Conversation

@ruchamahabal

@ruchamahabal ruchamahabal commented Jul 22, 2026

Copy link
Copy Markdown
Member

You can now move a block inside a slot/delete a slot from the layers panel. This is also helpful when the slot target is too small to drop into.

move-into-slot.mp4

@ruchamahabal
ruchamahabal marked this pull request as ready for review July 22, 2026 06:52
@greptile-apps

greptile-apps Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

Safe to merge — the new slot-drop path is well-guarded and state is cleared unconditionally before all early returns.

Drag state is destructured before clearDragState() so local references remain valid; the draggedElement! non-null assertion after the !draggedBlock guard is safe; slot vs. block deletion priority in the key handler is logically correct.

No files require special attention.

Reviews (3): Last reviewed commit: "fix: moving a block into an empty slot b..." | Re-trigger Greptile

Comment thread frontend/src/components/ComponentLayers.vue
@ruchamahabal ruchamahabal changed the title fix: allow moving a block inside a slot from layers panel fix: allow moving a block inside a slot and deleting a slot from layers panel Jul 22, 2026
@ruchamahabal
ruchamahabal merged commit c6d9b44 into frappe:develop Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant