Skip to content

feat: Access slot props, pass dynamic slots#200

Open
ruchamahabal wants to merge 14 commits into
frappe:developfrom
ruchamahabal:scoped-slots
Open

feat: Access slot props, pass dynamic slots#200
ruchamahabal wants to merge 14 commits into
frappe:developfrom
ruchamahabal:scoped-slots

Conversation

@ruchamahabal

@ruchamahabal ruchamahabal commented Jul 21, 2026

Copy link
Copy Markdown
Member

For components inside a slot:

image

You can now access slot scope/props:

slot-scope

Wiring slot scope in events:

slot-scope-event

Wiring slot scope

image

@ruchamahabal ruchamahabal changed the title feat: provide access to slot props feat: access slot props, pass dynamic slots Jul 23, 2026
@ruchamahabal ruchamahabal changed the title feat: access slot props, pass dynamic slots feat: Access slot props, pass dynamic slots Jul 23, 2026
@ruchamahabal
ruchamahabal marked this pull request as ready for review July 23, 2026 10:04
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

Safe to merge after the migration patch is updated — the patch's use of .save() will run all document hooks on every Studio Page and Component, which is slow and may trigger validation errors or on_update side-effects in production.

The migration patch calls frappe.get_doc().save() in a loop over all pages and components, running the full document lifecycle each time. Validation hooks may reject data that is otherwise valid for a raw update, on_update side-effects may fire unexpectedly, and version history is created for every record. Replacing with frappe.db.set_value is a straightforward fix before deploying.

studio/studio/doctype/studio_page/patches/migrate_slot_content_to_blocks.py — the save strategy needs to change before running this in production.

Reviews (9): Last reviewed commit: "fix: enlarge empty slot overlay space" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant