fix: implicitly allow dropping in a component that has a default slot + other slot fixes#199
Merged
Merged
Conversation
- else the canHaveChildren check won't work until the custom component block is selected
ruchamahabal
marked this pull request as ready for review
July 21, 2026 08:19
Contributor
Confidence Score: 5/5Safe to merge; the change correctly pre-warms slot caches and the only concern is duplicate network requests under concurrent construction of the same custom-component block. The logic is sound: startup pre-warming via frontend/src/utils/components.ts — Reviews (2): Last reviewed commit: "fix: register custom component slots & t..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old
canHaveChildren()check only allowed you to drop a component inside another one if:But in actual Vue components, wrapping a component around the other actually renders correctly if it just has a default slot. No explicit slot passing is required in this case.
This PR fixes that behaviour. You can now drop any component in another component if it has a default slot. For any other slot, you have to enable that slot from the Properties panel. This makes composition easier.
drop.mp4
Also fixes:
Stale slot options dropdown in properties panel even when you edit the Vue file in code. (needed a reload before this)
This PR also caches slots per component so that lookup becomes easier
Duplicate default slots shown in selector (all unnamed slots were considered as default branching from v-if regex)