fix: normalize keyboard shortcuts to ignore CapsLock and Shift casing#184
Open
AdnanQuazi wants to merge 2 commits into
Open
fix: normalize keyboard shortcuts to ignore CapsLock and Shift casing#184AdnanQuazi wants to merge 2 commits into
AdnanQuazi wants to merge 2 commits into
Conversation
Author
|
@ruchamahabal Please review this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where global keyboard shortcuts (
Ctrl+Z,Ctrl+D,Ctrl+F, etc.) would silently fail if the user hadCapsLockengaged or was holdingShift. It also fixes a minor bug inuseStudioEvents.tswhere thecanRedofunction was referenced but not actually executed in theCtrl+Shift+Zhandler.Root Cause
When
CapsLockorShiftis active,KeyboardEvent.keyreturns the uppercase character (e.g.,"Z"instead of"z"). Since the frontend used strict equality checks (e.key === "z"), these shortcuts failed to trigger under those conditions.Changes
helpers.ts: Introduced anisKey(e, key)helper that normalizes casing before comparison.useStudioEvents.ts: Replaced all raw.keyalphabet checks withisKey().SearchBlock.vue&ComponentInterface.vue&StudioRightPanel.vue: Applied theisKey()helper to local shortcuts (Ctrl+FandCtrl+S) for consistency.canRedotocanRedo()to ensure the redo stack check actually evaluates.Testing
CapsLockand verify thatCtrl+Z(Undo),Ctrl+Shift+Z(Redo),Ctrl+D(Duplicate) and other shortcuts work correctly on the canvas.