fix: don't flag comprehension predicates#43
Merged
nextchamp-saqib merged 1 commit intoJun 5, 2026
Merged
Conversation
…cates
`unchecked-frappe-permission-call` detects a discarded `frappe.has_permission`
return value by enumerating the "value is used" contexts (assignment, return,
if, ternary, assert). Using the call as a comprehension predicate isn't in that
list, so a perfectly safe filter is flagged as a false positive:
permitted = [d for d in doctypes if frappe.has_permission(d, "read")]
Add pattern-not-inside exclusions for list/set/dict comprehensions and
generator expressions, and add test fixtures for this rule (there were none),
covering both the discarded-call case (still fires) and the use-as-predicate
cases (no longer fire).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
nextchamp-saqib
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unchecked-frappe-permission-callflags discardedfrappe.has_permissioncalls by listing the contexts where the value is used (assign/return/if/ternary/assert). Comprehension predicates are missing, so this false-positives:Adds
pattern-not-insideexclusions for list/set/dict comprehensions + generators (deep-expr operator, so negated predicates count), and adds the rule's first fixtures.make test→ 29/29 ✓.