Repository navigation
feat: default site backups - #672
Merged
AyshaHakeem merged 8 commits intoOct 21, 2026
Merged
Conversation
Contributor
 [High impact] The PR appears safe to merge; no actionable new issues remain. Reviews (4) · Last reviewed commit: "test: Refactor tests" · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Add a calendar_rotation flag to backup retention. With it, every run is kept for 7 days, Sunday runs for 28 days, runs on the 1st of a month for 366 days and January 1 runs for 3653 days. The newest run is always kept.
New sites, and sites restored from a backup, now get daily backups with calendar GFS retention unless the user sets a custom schedule. A custom schedule replaces the default. One hourly cron job per bench reads the audit log once and queues a backup for each default site with no successful backup in 23 hours. The first backup of a day includes files. A site is skipped for the day after six failures.
The sixth failed backup since the last successful one adds a "Backups of <site> are failing" error to the notification feed.
A post-update patch enrolls each existing site that has no backup schedule in the default backups. Sites with a custom schedule keep it.
The Backups page shows "Daily, with the default retention policy." for a site on the default backups. The config dialog opens enabled with the default retention, so saving it sets a custom schedule.
… writes the retention record second
AyshaHakeem
force-pushed
the
feat/default-site-backups
branch
from
October 21, 2026 08:40
11a1412 to
c31bc79
Compare
Contributor
Author
|
@greptileai retrigger confidence score check |
Contributor
Author
|
closes #625 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch: it enrolls only sites with no
backup_retentionrecord. Sites with a custom schedule keep it.