Repository navigation
feat(sites): allow mailbox connect calls to central - #669
Open
RitvikSardana wants to merge 1 commit into
Open
RitvikSardana wants to merge 1 commit into
RitvikSardana wants to merge 1 commit into
Conversation
This was referenced Oct 18, 2026
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. Reviews (2) · Last reviewed commit: "feat(sites): allow mailbox connect calls..." · Reviewed by Greptile |
RitvikSardana
force-pushed
the
feat/email-oauth-relay
branch
from
October 18, 2026 18:24
3d17074 to
0d6ab2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Lets a site reach Central's mailbox sign-in endpoints through its Pilot, so a site on Frappe Cloud V2 can connect a Microsoft 365 mailbox in one click.
central.api.email_oauth.startandcentral.api.email_oauth.relay_tokento the Central proxy's exact-name allowlist. The browser callback stays off the proxy: the browser goes to Central directly.Testing
python -m pytest tests/pilot/integrations/test_central_client.py: 28 passed.Related to frappe/central#506