Skip to content

feat(sites): allow mailbox connect calls to central - #669

Open
RitvikSardana wants to merge 1 commit into
frappe:developfrom
RitvikSardana:feat/email-oauth-relay
Open

RitvikSardana wants to merge 1 commit into
frappe:developfrom
RitvikSardana:feat/email-oauth-relay

Conversation

@RitvikSardana

Copy link
Copy Markdown
Member

What this does

Lets a site reach Central's mailbox sign-in endpoints through its Pilot, so a site on Frappe Cloud V2 can connect a Microsoft 365 mailbox in one click.

  • Adds central.api.email_oauth.start and central.api.email_oauth.relay_token to the Central proxy's exact-name allowlist. The browser callback stays off the proxy: the browser goes to Central directly.
  • New test: a POST to either method is forwarded to Central with its body.

Testing

  • python -m pytest tests/pilot/integrations/test_central_client.py: 28 passed.
  • Used by a real Microsoft 365 mailbox connect on a local setup (a V2 site, this Pilot and Central).

Related to frappe/central#506

@greptile-apps

greptile-apps Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Reviews (2) · Last reviewed commit: "feat(sites): allow mailbox connect calls..." · Reviewed by Greptile

Comment thread admin/backend/api/v1/sites/central.py
@RitvikSardana
RitvikSardana force-pushed the feat/email-oauth-relay branch from 3d17074 to 0d6ab2d Compare October 18, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant