This repository was archived by the owner on Aug 16, 2022. It is now read-only.
Minor improvements in frappejs - #117
Open
MaxMorais wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@netchampfaris I'm sending 4 minor improvements to frappejs, there's a description why
1 - I got few errors installing frappebooks from source, because functions was being serialized and sent to DDL during the creation of tables.
2 - Trying some entries in frappebooks, I got few errors due the fact, that the framework is calling the method
roundFloatsin children, but not all children have that method3 - If we create a select with a list of objects with the options notation
{value: '', label: ''}the message is unclear4 - If we create a select with a list of objects in options that select dont will be properly rendered on UI