Frappe Draw: show in the Desk /apps launcher (add_to_apps_screen + logo)#18
Merged
Conversation
Enable the app-launcher entry so Frappe Draw appears on the Desk /apps screen, using the brand logomark (the violet 3-node hierarchy mark) as a served asset. - draw/public/logo.svg: the brand mark (same as the favicon), served at /assets/draw/logo.svg. - hooks.py: uncomment + wire add_to_apps_screen (name/logo/title/route + has_permission). - api/permission.py: has_app_permission(user) — any signed-in (non-Guest) user. Verified: logo serves (200 at /assets/draw/logo.svg); app loads + run-tests --app draw → 9 pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Confidence Score: 5/5Three-file change is self-contained: a new SVG asset, an uncommented hooks entry, and a one-line permission function. No existing behaviour is modified. All three files are additive only. The permission function is a standard Frappe pattern, the asset path follows framework conventions, and no existing logic is touched. No files require special attention. Reviews (1): Last reviewed commit: "Frappe Draw: show in the Desk /apps laun..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Enable the app-launcher entry so Frappe Draw appears on the Desk /apps screen, using the brand logomark (violet 3-node hierarchy mark) as a served asset.
draw/public/logo.svg— brand mark (same as the favicon), served at/assets/draw/logo.svg.hooks.py— wireadd_to_apps_screen(name/logo/title/route + has_permission).api/permission.py—has_app_permission(user): any signed-in (non-Guest) user.Testing
Logo serves (200 at
/assets/draw/logo.svg); app loads +run-tests --app draw→ 9 pass.🤖 Generated with Claude Code