Frappe Draw: unified-canvas polish (minimap coverage + library type filter)#17
Merged
Conversation
…filter - Minimap: on a unified doc, the navigator now overviews ALL content — block shapes + whiteboard objects + the mind-map / flowchart frames (offset by their origin) — instead of only block shapes. (whiteboardObjectBoxes + per-frame layout, added as an isUnifiedDocument branch in items().) - Library: add 'unified' (label "Drawing", the current default type) to DIAGRAM_TYPES, so unified diagrams are filterable in the home type filter and their tiles read "Drawing" instead of falling back to "Block". Verified: build + 101 JS tests + live app — a unified doc with a block shape, a pen stroke, a mind-map frame and a flowchart frame shows all of them in the minimap (6 glyphs incl. viewport rect). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Confidence Score: 4/5Safe to merge; the only gap is that connector lines are missing from the unified minimap, which is a cosmetic omission rather than a functional breakage. The two changed files are small and self-contained. The frontend/src/components/canvas/Minimap.vue — the Reviews (1): Last reviewed commit: "Frappe Draw: unified-canvas polish — min..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
unified(label "Drawing") toDIAGRAM_TYPES, so unified diagrams are filterable in the home type filter and their tiles read "Drawing" (not the "Block" fallback).Testing
Build ✅ · 101 JS tests ✅ · live app ✅ — a unified doc with block + pen stroke + mind-map + flowchart shows all of them in the minimap (6 glyphs incl. viewport).
🤖 Generated with Claude Code