Skip to content

fix: show users in email multiselect - #3072

Merged
ps173 merged 1 commit into
frappe:developfrom
ps173:fix/email-multiselect-users
Oct 15, 2026
Merged

ps173 merged 1 commit into
frappe:developfrom
ps173:fix/email-multiselect-users

Conversation

@ps173

@ps173 ps173 commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

EmailMultiSelect destructured allUsers straight from the users store. Pinia unwraps the computed to a plain array on destructuring, so allUsers.value was undefined and the users list was always empty. That affected the Add Existing User modal. This uses storeToRefs so the list stays reactive and updates once the full user fetch lands.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@mergify

mergify Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@greptile-apps

greptile-apps Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This change appears safe to merge.

Reviews (1) · Last reviewed commit: "fix: show users in email multiselect" · Reviewed by Greptile

@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (9f214ef) to head (579d45c).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3072      +/-   ##
===========================================
+ Coverage    76.56%   76.73%   +0.17%     
===========================================
  Files          190      194       +4     
  Lines        14916    15081     +165     
===========================================
+ Hits         11421    11573     +152     
- Misses        3495     3508      +13     

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ps173
ps173 merged commit 91940bd into frappe:develop Oct 15, 2026
14 checks passed
ps173 added a commit that referenced this pull request Oct 15, 2026
fix: show users in email multiselect (backport #3072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants