Repository navigation
fix(email-oauth): do not follow redirects when sending the client secret to the token URL - #525
Merged
prathameshkurunkar7 merged 2 commits intoOct 22, 2026
Conversation
…ret to the token URL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
exchange_tokensends a POST request to the token URL of the Email OAuth Provider. The body of the request has the client secret.relay_tokenuses this request for a sign-in code and for a refresh token.By default,
requestsfollows a redirect. If the token URL answers with a 307 or a 308 redirect,requestssends the same POST request again to the new address. The body of that request has the client secret. Thus, a wrong token URL, or a token URL on a host that changes owner, can send the client secret to a different server.Solution:
exchange_tokennow sends the request withallow_redirects=False. Central sends the client secret only to the token URL of the Email OAuth Provider. A sign-in and a token refresh work as before, because the token URL of Microsoft does not redirect.Related to #506