Elevation: world-class README + Pages landing, validate CI, governance#2
Conversation
- README: animated hero, badge family, Mermaid loop, the five-files table, family footer - scripts/validate-protocol.mjs + .github/workflows/validate.yml: assert the five files + weekly template exist, SPEC references them, and local links resolve - docs/index.html: premium gold/violet Pages landing for the protocol (+ .nojekyll) - governance: CODE_OF_CONDUCT, issue templates (config + proposal), PR template - .github/hero.svg + og.svg https://claude.ai/code/session_01NRZWrqfgHPAfFWKxfQUqjE
|
Warning Review limit reached
More reviews will be available in 22 minutes and 26 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request introduces community templates, documentation, assets, and a validation script for the Blessing Protocol. Specifically, it adds GitHub issue and pull request templates, SVG graphics, a Code of Conduct, contributing guidelines, a landing page, and updates the README with badges and a Mermaid diagram. Additionally, a Node.js validation script is introduced to verify template existence, spec references, and local markdown links. The review feedback highlights two key improvements for the validation script: updating the regular expression to correctly match outer links of nested markdown image badges, and enhancing the link resolution logic to support URL decoding and relative path resolution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if (!existsSync(p("ATTESTATION.md"))) errors.push("missing ATTESTATION.md"); | ||
|
|
||
| // 4. local markdown links resolve | ||
| const LINK_RE = /\[[^\]]*\]\(([^)]+)\)/g; |
There was a problem hiding this comment.
The current regular expression /\[[^\]]*\]\(([^)]+)\)/g fails to match the outer link of markdown image badges (e.g., [](target)). Because the inner bracket ] terminates the [^\]]* match early, the outer link target is completely ignored by the validator.
Using a simpler pattern like /\]\(([^)]+)\)/g successfully captures all link and image destinations, including nested badge links.
| const LINK_RE = /\[[^\]]*\]\(([^)]+)\)/g; | |
| const LINK_RE = /\]\(([^)]+)\)/g; |
| let target = m[1].trim(); | ||
| if (/^(https?:|mailto:|#)/.test(target)) continue; // external or anchor | ||
| target = target.split("#")[0].split("?")[0]; | ||
| if (!target) continue; | ||
| if (!existsSync(resolve(ROOT, target))) { | ||
| errors.push(`${file}: broken local link → ${target}`); | ||
| } |
There was a problem hiding this comment.
There are two key improvements for the local link resolution logic:
- URL Decoding: If a local link contains URL-encoded characters (such as
%20for spaces),existsSyncwill fail to find the file on disk. Wrapping the target indecodeURIComponentresolves this. - Relative Path Resolution: Resolving paths relative to
ROOTworks only for files at the root directory. Resolving them relative to the directory of the file being validated (dirname(p(file))) makes the validator robust and future-proof if files in subdirectories are added to the check list.
let target = m[1].trim();
if (/^(https?:|mailto:|#)/.test(target)) continue; // external or anchor
target = decodeURIComponent(target.split("#")[0].split("?")[0]);
if (!target) continue;
const dir = dirname(p(file));
if (!existsSync(resolve(dir, target))) {
errors.push(`${file}: broken local link → ${target}`);
}There was a problem hiding this comment.
Pull request overview
This PR “elevates” the bless repository’s presentation and project hygiene by adding a GitHub Pages landing page, a CI validator for protocol invariants/links, and standard community/governance files, alongside refreshed README visuals and repo branding assets.
Changes:
- Added a zero-dependency Node validator (
scripts/validate-protocol.mjs) and a GitHub Actions workflow to enforce template/spec/link invariants. - Introduced a
docs/GitHub Pages landing page (with.nojekyll) and new SVG branding assets for README/OG. - Added/updated governance and contribution scaffolding (Code of Conduct, PR template, issue templates, CONTRIBUTING).
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
scripts/validate-protocol.mjs |
Adds CI guardrails for required templates, SPEC references, attestation presence, and local link validation. |
README.md |
Adds hero SVG, badges, navigation, a Mermaid loop diagram, and “Blessing family” section. |
docs/index.html |
Adds a styled GitHub Pages landing page describing the protocol and linking to the repo/spec. |
docs/.nojekyll |
Ensures Pages serves assets without Jekyll processing. |
CONTRIBUTING.md |
Adds contribution guidelines and expectations (incl. validator usage and spec-change process). |
CODE_OF_CONDUCT.md |
Adds a Contributor Covenant-based Code of Conduct and reporting channel. |
.github/workflows/validate.yml |
Adds CI job to run the validator on pushes/PRs to main. |
.github/PULL_REQUEST_TEMPLATE.md |
Adds a PR template aligned with protocol/spec governance. |
.github/og.svg |
Adds OG image asset for social previews. |
.github/ISSUE_TEMPLATE/proposal.yml |
Adds a structured proposal form for protocol changes. |
.github/ISSUE_TEMPLATE/config.yml |
Configures issue creation flow and provides contact links. |
.github/hero.svg |
Adds animated README hero SVG. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const LINK_RE = /\[[^\]]*\]\(([^)]+)\)/g; | ||
| for (const file of ["README.md", "SPEC.md", "CONTRIBUTING.md"]) { | ||
| if (!existsSync(p(file))) continue; | ||
| const text = readFileSync(p(file), "utf8"); |
| * 1. the five standard templates + weekly.md exist under templates/ | ||
| * 2. SPEC.md references each of the five files + weekly.md | ||
| * 3. ATTESTATION.md exists | ||
| * 4. every local markdown link in README.md + SPEC.md resolves on disk |
| .quote{font-family:var(--serif);font-size:clamp(22px,3.4vw,32px);line-height:1.35;max-width:46rem} | ||
| .quote em{font-style:italic;color:var(--gold)} | ||
| footer{padding:48px 0 80px;color:var(--muted);font-family:var(--mono);font-size:12px;text-align:center;border-top:1px solid var(--hair)} | ||
| @media (prefers-reduced-motion:reduce){.seal{animation:none}} |
Elevates
blessto world-class with the new Blessing-family identity (blessed gold#f4c97a+ witness violet#c9b6ff)..github/hero.svg), badge family, Mermaid loop diagram, the five-files table, the family-constellation footer.scripts/validate-protocol.mjs+.github/workflows/validate.yml— asserts the five templates +weekly.mdexist, SPEC references them, and every local link resolves. (Runs green locally.)docs/index.html— a premium gold/violet landing for the protocol (+.nojekyll).CODE_OF_CONDUCT.md, issue templates (config + proposal form), PR template. (CONTRIBUTING.mdalready present.).github/og.svg.Additive only — the merged v0.1 spec + templates are untouched. Verified:
node scripts/validate-protocol.mjs→ OK; hero/og valid XML; index.html well-formed.Part of a four-repo elevation (bless · mind-palace-agent-skills · frankx-mind-palace · frankx-palace).
https://claude.ai/code/session_01NRZWrqfgHPAfFWKxfQUqjE
Generated by Claude Code