Main-release foundation: identity hygiene, governance/support docs, runtime tracking - #81
Merged
Conversation
…me tracking) Identity hygiene: migrate 19 internal Logger subsystems and NotificationCenter names off the archived com.isaacmarovitz.Whisky namespace onto com.franke.Whisky (notification names are single-source constants, so posters/observers stay matched), and repoint two in-app diagnostic report URLs to the fork's issue tracker instead of the read-only upstream. Sustainability/intake docs: add docs/GOVERNANCE.md (honest single-maintainer continuity stance), docs/SUPPORT.md (where to file and what to expect), and docs/DEPENDENCIES.md (pinned Wine/DXVK/D3DMetal/DXMT runtime components, their upstream sources, and the tracking cadence). Runtime currency: add the RuntimeTrack workflow that opens an issue when a bundled runtime component falls behind upstream, and replace the 'Wine build is out of scope' line in ReleaseWorkflow.md with a reproducible assembly procedure. The bug-report template now confirms the reporter is running this fork rather than the archived original that the default Homebrew cask installs.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Review follow-ups: - CHANGELOG linked .planning/DEPENDENCIES.md; the file is at docs/DEPENDENCIES.md. - RuntimeTrack.yml dropped 'gh issue create --label runtime' (the label may not exist, which aborts the step under set -euo pipefail), and latest_tag() now distinguishes an API error from 'no releases' so a transient failure no longer files a spurious drift issue. - DEPENDENCIES.md no longer claims D3DMetal/GPTK is auto-polled (it has no GitHub release feed) — it's documented as manually tracked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Now that the v1.0 milestone closed the upstream issue backlog, the next goal is making this fork the project people trust as the ongoing Whisky. A review flagged the two structural risks that actually archived the original — letting the bundled Wine runtime silently go stale, and a single-maintainer bus factor — as the things still unaddressed. This is the low-risk first pass at both, plus identity cleanup.
What's in here
Identity hygiene
Loggersubsystems andNotificationCenternames off the archivedcom.isaacmarovitz.Whiskynamespace ontocom.franke.Whisky. Each notification name is a single-sourceNotification.Nameconstant referenced symbolically, so posters and observers stay matched.WhiskyWineSetupDiagnostics,WinePrefixDiagnostics) from the read-only upstream to the fork's issue tracker.whisky-app/whisky#NNNcode comments untouched — correct historical provenance.Sustainability & intake docs
docs/GOVERNANCE.md— honest single-maintainer continuity stance.docs/SUPPORT.md— where to file, what to expect, fork-vs-archived disambiguation.docs/DEPENDENCIES.md— pinned Wine / DXVK / D3DMetal / DXMT runtime components, sources, and tracking cadence (incl. why DXVK 1.10.3 is correct rather than stale).Runtime currency
.github/workflows/RuntimeTrack.yml— weekly poll that opens/updates a tracking issue when a bundled runtime component falls behind upstream. Triggered only byschedule/workflow_dispatch; the one external value (upstream release tag) flows through shell variables, never${{ }}interpolation.docs/ReleaseWorkflow.md— replaced the "Wine build is out of scope" line with a reproducible runtime-assembly procedure.Verification
xcodebuild -scheme Whisky -configuration Debug build→ BUILD SUCCEEDEDswift test --package-path WhiskyKit→ passingswiftformat --lint→ clean (pre-commit hook also passed)grep -rn com.isaacmarovitz.Whisky/Whisky-App/Whisky/issuesinWhisky/+WhiskyKit/→ 0Not in this PR (follow-up passes)
High-CPU pipe-spin fix (upstream PR #1374 + #1305), DXMT graphics backend, in-app bottle migration wizard, app-target coverage CI job, localization dot-key cleanup.