refactor!: drop clickonce support - #254
Conversation
games do not arrive as .appref-ms deployments, and nobody spoke up for it during the window on frankea#215. the manager, its detection pass in the program scan, the badge, the context menu, the .net auto-recommendation and the appref file type in the run panels all go. the clickonce-cache noise filter in the exe scan stays, a prefix can still contain the artifacts. ClickOnceManager, the Program(appRefURL:bottle:displayName:) initializer and isClickOnce were public WhiskyKit API, so the kit needs a major bump. BREAKING CHANGE: ClickOnceManager, Program(appRefURL:bottle:displayName:) and Program.isClickOnce are removed from WhiskyKit's public API. Closes frankea#215
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
frankea
left a comment
frankea
left a comment
There was a problem hiding this comment.
Verified hands-on on top of current main (post #239): clean merge with zero conflicts including the two hot files, all three app schemes build (Whisky, WhiskyCmd, WhiskyThumbnail), and the kit suite passes at 249 tests in 35 suites, which reconciles exactly against main's 267 in 36 (ClickOnceManagerTests held 18 tests in 1 suite). The kept noise-filter test runs and passes, swiftformat reports 0/401 and swiftlint strict is clean tree-wide on the merged result.
Details checked: the xcstrings edit removes exactly the six program.clickonce.* keys with the remaining 884 entries byte-for-byte in their existing order, and no source references any removed key; DependencyManager merges against #239 with only the ClickOnce step gone and the evidence sources renumbered consistently; the changelog entry sits correctly under Unreleased and names the public API removal (ClickOnceManager, the appRefURL initializer, isClickOnce) with the kit major bump called out; the cache noise filter survives exactly as agreed on #215, in the scan and its test.
Thanks for reapplying by hand on upstream/main instead of cherry-picking across the divergence, and for landing this within hours of the green light. Merging.
2 participants
closes #215.
games do not arrive as
.appref-msdeployments. the end-of-august window passed with nobody speaking up, and the preview fork has been silent on it since 2026.8.12.what goes
ClickOnceManagerand its testsBottle+Extensions)isClickOncecom.microsoft.application-referencefile type in the run panelprogram.clickonce.*localisation keyswhat stays
the clickonce-cache noise filter in the exe scan, as agreed. a prefix can still contain those artifacts whether or not we support launching them.
public api
ClickOnceManager,Program(appRefURL:bottle:displayName:)andProgram.isClickOncewere public WhiskyKit API, so this needs the major bump. flagged in the changelog under Removed with the api surface named, and the commit carries aBREAKING CHANGE:footer.checks
reapplied by hand on
upstream/mainrather than cherry-picked, since preview has diverged. 249 tests in 35 suites pass, swiftformat lint reports 0/399, swiftlint strict finds 0 violations.