Run the vcrun verbs unattended - #244
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Whisky runs winetricks without -q, so the vc_redist installer is not unattended: it shows its setup wizard inside the prefix and waits for a click that nothing in the Dependencies panel prompts for. The process never exits, winetricks never writes the log entry, and the panel keeps reporting "Not Installed" even when the runtime installed fine (frankea#233). Pass -q (W_OPT_UNATTENDED, which adds /q to the redist install) for the vcrun verbs, alongside the existing --force. Scoped to the vcrun path rather than globally until other verbs are checked for unattended behavior.
2683308 to
e3e7f3c
Compare
|
Verified hands-on on the merged tree rather than from the diff: Debug build of the app target compiles the changed file, the full WhiskyKit suite passes (1304 XCTest, 267 Swift Testing), SwiftLint strict and SwiftFormat 0.58.7 clean. The claim checks out against the bundled winetricks (20260125): I hit exactly the symptom this fixes earlier today while smoke testing 3.7.0: vc_redist.x86.exe sat under the burn bootstrapper for minutes with the install sheet showing 24 log lines and no hint. Thank you for tracking it down. The only thing blocking the merge was an adjacent-insert conflict in CHANGELOG.md against entries that landed today; I rebased the branch onto main and resolved it by keeping both sides, no change to the Swift. Merging. |
Whisky runs winetricks without -q, so the vc_redist installer is not
unattended: it shows its setup wizard inside the prefix and waits for a
click that nothing in the Dependencies panel prompts for. The process
never exits, winetricks never writes the log entry, and the panel keeps
reporting "Not Installed" even when the runtime installed fine
(#233).
Pass -q (W_OPT_UNATTENDED, which adds /q to the redist install) for the
vcrun verbs, alongside the existing --force. Scoped to the vcrun path
rather than globally until other verbs are checked for unattended
behavior.