docs: uninstall guide, #1010 citation, open-PR audit - #116
Merged
Conversation
- README: add an Uninstalling section listing every on-disk path a full removal must delete (addresses Whisky-App/Whisky#1206). - CHANGELOG: cite Whisky-App/Whisky#1010 on the existing idle-CPU fix so the upstream-issue audit credits it. - AUDIT.md: add an Open upstream PRs section reviewing the 9 PRs left open at upstream archival, closing the tool's documented no-PR-correlation gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of four follow-ups from the upstream open-issue/PR review. Docs-only — so this is also the first real exercise of the docs-skip CI from #115 (the macOS build/test jobs should not run here).
Changes
README — Uninstalling section (addresses upstream #1206): the original ask was "document how to completely remove Whisky," since trashing the app leaves the Wine runtime, bottles, and app data behind. Adds the exact
~/Librarypaths to delete (container/bottles, Application Support runtime, caches/logs/prefs/HTTPStorages, thumbnail extension container), with a back-up-your-bottles warning and a note that custom-location bottles and migratedcom.isaacmarovitz.Whiskybottles are left untouched. Paths verified againstBottleData.containerDir,WhiskyWineInstaller, and what's actually on disk.CHANGELOG — cite #1010: the idle-CPU fix shipped in 3.1.0 already closes the famous "100% CPU the entire time" bug, but only cited #917. Added #1010 so the upstream-issue audit credits the fix (it was reading as unaddressed purely for lack of a citation).
docs/AUDIT.md — Open upstream PRs section: the audit tool explicitly listed "no upstream-PR correlation" as a blind spot. This records a hand review of all 9 PRs open at upstream archival. Every bug-fix PR (#1374, #1305, #1264, #1339) is resolved — several more thoroughly than the upstream patch. Remaining items are tracked honestly as gaps/feature-choices (#574 async loading, #765 custom update UI, #571 menu bar) and will flip to "done" as their follow-up PRs land.
No code changes.