fix(security): seed demo account as user, not admin (P4.4) - #54
Merged
Conversation
Assisted-by: Claude Code (Haiku) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Assisted-by: Claude Code (Haiku) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
Summary
The Prisma seed created the demo account (
demo@lexforge.app) withrole: 'admin', which grants cross-user audit-log visibility. Downgraded torole: 'user'. Single-line change (seed.js:360), no other admin dependency in the seed.OWNER-GATED (does not block this fix)
Confirm whether
seed.jswas ever run against the Neon prod DB.render.yamldoes not auto-run it, but if it was run manually, the weak-password admin account is live and should be rotated/removed in prod after this merge.Red-first / tests
Red commit
b761147(assert seeded demo user role isuser, initially failing on'admin') → green03b2d88. Addedupsertto the fake Prisma client to support the seed test.Verification
server/npm test: 233 passed.Gate
One-line role change + red test; diff reviewed directly, no secrets, no other logic touched.
Assisted-by: Claude Code (Fable orchestrator + Haiku implementer)